fix(timeline): fix tickFormat being ignored#4463
Merged
GordonSmith merged 1 commit intoOct 16, 2025
Merged
Conversation
GordonSmith
requested changes
Oct 14, 2025
GordonSmith
requested changes
Oct 14, 2025
Member
GordonSmith
left a comment
GordonSmith
left a comment
There was a problem hiding this comment.
acutally it would be called "_reset" similar to "_exists"?
Fixes an issue where tickFormat called by consumers of this component was being ignored / overwritten by _axisLabelFormatter. This resulted in d3-time-format defaulting back to it's 12-hour "AM/PM" notation Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
jeclrsg
force-pushed
the
fix-eclwatch-timeline-formatting
branch
from
bda790a to
d5d13fb
Compare
GordonSmith
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where tickFormat called by consumers of this component was being ignored / overwritten by _axisLabelFormatter. This resulted in d3-time-format defaulting back to it's 12-hour "AM/PM" notation
Checklist:
Testing: